Editing Vendor template fails

uhdamm

Vendor templates is a great feature, and maintaining general vendors globally, makes a lot of sense.

Unfortunatelly I run into an error, when editing a Vendor template.

This is the change:

Error: HTTP ERROR 500

Using the back button, Account Manager name has been changed, but not on all Clients where that template is assigned.

Same can be reproduced on demo env.

PHP log:

[Thu Oct 31 18:40:13.748789 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_name" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 31, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.748909 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_description" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 37, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749011 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_account_number" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 43, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749185 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_contact_name" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 49, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749330 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_phone" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 55, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749448 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_hours" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 61, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749554 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_email" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 67, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749675 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_website" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 73, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749778 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_sla" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 79, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749883 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_code" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 85, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.749959 2024] [php:warn] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Warning: Undefined array key "global_update_vendor_notes" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 91, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 18:40:13.751643 2024] [php:error] [pid 65770:tid 65770] [client 87.62.96.89:36946] PHP Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE vendor_template_id = 25' at line 1 in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php:107\nStack trace:\n#0 /var/www/msp.mydomin.dk/post/admin/admin_vendor_template.php(107): mysqli_query()\n#1 /var/www/msp.mydomain.dk/post.php(32): require_once('...')\n#2 {main}\n thrown in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 107, referer: https://msp.mydomain.dk/admin_vendor_template.php

Editing Vendot template Notes:

Almost same thing happens, when editing Vendor Template Notes - enabling "Update Notes Globally"

No HTTP error, and the note is the Vendor template is changed, however the change is not visible on any of the clients with that template assigned.

PHP log:

[Thu Oct 31 19:01:36.104715 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "vendor_template_id" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 29, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105224 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_name" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 31, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105337 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_description" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 37, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105459 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_account_number" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 43, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105565 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_contact_name" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 49, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105659 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_phone" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 55, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105769 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_hours" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 61, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.105932 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_email" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 67, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.106052 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_website" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 73, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.106162 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_sla" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 79, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.106261 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "global_update_vendor_code" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 85, referer: https://msp.mydomain.dk/admin_vendor_template.php

[Thu Oct 31 19:01:36.108216 2024] [php:warn] [pid 65767:tid 65767] [client 87.62.96.89:15897] PHP Warning: Undefined array key "update_base_vendors" in /var/www/msp.mydomain.dk/post/admin/admin_vendor_template.php on line 100, referer: https://msp.mydomain.dk/admin_vendor_template.php

Thx 😊

johnny

Hi @uhdamm I believe you are just updating the template itself which mean if you add a new vendor using the template it will resemble what you just updated

however

if you check the boxes on the right next to the input fields it will push the update out to all clients that have the vendor template assigned.

This is done because you may not want to push out certain changes to all the clients vendors

We are open to ideas / feedback of a better UX / UI ideas regarding vendor templates as well

uhdamm

Thx johnny

So what you are telling me is:

"Update all base vendors" tells the application, that I want to change one or more fields for that Vendor, and make it global for all assigned clinets.
And next I have to click the checkbox next to the fields I need changed, before I hit "Update template"?

I see that part working here now, with no error, however edits to the "notes" tab needs both "Update All Base Vendors" and "Update Notes Globally?" checked. A bit cumbersome - but working 😊

Would it be possible to make it a bit easier?

Do we actually need "Update All Base Vendors", Eg. if the box next to a field is checked, make the change globally.
Would that work?

wrongecho

uhdamm

Do we actually need "Update All Base Vendors", Eg. if the box next to a field is checked, make the change globally.

Have not touched this side of the code at all, but I would imagine if you don't tick the box it's only going to update the template for use with future vendors? Checking the box means it'll update the existing vendors based off that template too?