First development/contribution attempt

whatthemeh

I made some small modifications and i believe submitted them. However, I am not sure I submitted them properly to perhaps i didn't submit them to the proper branch?

This is my cherry pop moment for using GITHub and working with others so wanted to make sure i did all of that correctly before I look to do anything else.

johnny

Nice works @whatthemeh Ill review it and give any feedback. Thank you!!

whatthemeh

another question before i look at doing anything else i took a peak at the open issues listed in GitHub. I only see the CSP item as anything that help was needed. is that still the case? not that i am an expert in that by any mean but certainly willing to try and help where/when i can

johnny

Hey @whatthemeh

We now use https://tasks.dev.itflow.org/

I can send you an invite to your email if youd like

whatthemeh

oh that would be awesome. i would certainly not mind trying to contribute more

johnny

Awesome,

I just created your account, Use this forgot password link and put the email you used to signup with the forums in there, and it will reset your password

https://tasks.dev.itflow.org/forgot_password.php

whatthemeh

Good morning and happy monday. I have a question about pull requests. Since mine was closed i believe that means it wasn't implemented? I was wondering if that was due to the automatic check errors? initially when i submitted it everything passed so i am sure i messed something up when trying to update what went to grab the latest changes and put them into my branch (realizing now i probably should not have done that)

just looking for any feedback since I am new at contributing to a project.

Thanks

wrongecho

Hey, happy Monday.

If you're referring to this PR, I assumed you broke something in git/Github while raising it as it was showing as having 250+ files edited. Feel free to reopen if this wasn't a mistake.

whatthemeh

yeah i thought i might have f'd something after i submitted. I believe i created the branch was before there were changes made to the file structure and where things were stored and my attempt to reflect those probably F'd it all up.

I redo and resubmit

Thanks