I could ask for approval / rejection - the project has been hanging around for quite a while now. Thx ;-)
Manage... add posibility to add prefix for client tickets
Hey,
Appreciate the effort in the PR. Translation/Localisation is definitely something we want but we almost definitely want to use something like gettext. We can't create a database column for every single heading/wording we use in the app!
Not sure you mean about the prefix, we have a numbering prefix already?
that'd be great as well as custom prefix per client vs global.
client1-ticket1
client2-ticket1
client1-invoice1
client2-invoice1
etc
Reviewing PRs is actually more effort/work than writing code, for me at least. That PR includes two new different features.
The localisation doesn't seem to be the extensible approach we'd want - see the gettext approach.
The other part about custom prefixes is something we need to decide if we actually want. Personally, I struggle to understand the use case.
I really do appreciate the enthusiasm and I'm not trying to put you off contributing, but we have learned a lot over the past 3 or so years about ensuing all contributions fit our project vision as a whole. We end up having to maintain whatever is added. Unless a feature is likely to be useful to the majority of users then it's unlikely to be added into the core code. We're not looking to add loads of bloat to accommodate lots of different edge cases - there are already plenty of solutions (e.g. ServiceNow) that do that - and are incredibly slow to do anything with.