Quotes - Submitting forms redirects to post.php

Brodur

I'm seeing an issue with the latest git pull that occurs when submitting a form.

Example steps to reproduce - create a quote, enter a line item, and click the checkmark. The page will redirect to post.php. This behaviour is also present on the demo site.

Pressing back will show that the change took affect - so annoying but not a show-stopper.

psiiota

Can you run tail -f /var/log/apache2/error.log

Brodur

Here are some of the most recent apache/php errors.

[Moved logs to pastebin: https://pastebin.com/26iLZRh4 ] -wrongecho

psiiota

@johnny or @wrongecho any ideas?

wrongecho

Hello @Brodur

Thanks for getting in touch.

It seems this relates to just quotes? I've renamed the thread as appropriate. Is this is incorrect, please let me know.

I've just navigated to the demo and created a quote - works fine. I then added a line item to the quote - also fine. I'm also unable to replicate on my personal dev instance.

Could you please advise?

Also, with regards to posting logs: Please FIRST run the tail command and then post all error logs that are shown WHILST/AFTER you complete the action. 200 lines of logs won't really help us in narrowing anything down. It's also generally considered good etiquette to use pastebin or something similar if you're posting more than a few lines - it makes discussions difficult to follow.

psiiota

wrongecho Imma adjust my instructions there. Thanks

johnny

yeah I cant reproduce here either on any of my instances.

@Brodur Please check for updates again to see if anything was missed, sometimes the page will get cached and not show updates, so you might want to clear web cache as well.

Brodur

Well, glad I could be an example of what not to do. From your statements I'm wondering if it could be a browser issue. I'm using Firefox currently.

Just tested on Chrome, and confirmed that the forms behave as normal.

Confirmed on Firefox that I can reproduce the behavior under Administration > Taxes and trying to update a tax code there.

[Wed Oct 25 17:33:51.673564 2023] [fcgid:warn] [pid 22838] [client 10.0.10.26:41414] mod_fcgid: stderr: PHP Notice: Undefined index: HTTP_REFERER in /home/example/domains/itflow.internal.example.com/public_html/post/tax.php on line 36

And for posterity where I originally noticed it on Quotes:

[Wed Oct 25 17:35:14.032424 2023] [fcgid:warn] [pid 10669] [client 10.0.10.26:60014] mod_fcgid: stderr: PHP Notice: Undefined variable: client_is_lead in /home/example/domains/itflow.internal.example.com/public_html/client_edit_modal.php on line 112

[Wed Oct 25 17:35:16.082221 2023] [fcgid:warn] [pid 22837] [client 10.0.10.26:60016] mod_fcgid: stderr: PHP Notice: Undefined variable: client_is_lead in /home/example/domains/itflow.internal.example.com/public_html/client_edit_modal.php on line 112

[Wed Oct 25 17:35:24.759474 2023] [fcgid:warn] [pid 22838] [client 10.0.10.26:54194] mod_fcgid: stderr: PHP Notice: Undefined variable: json_products in /home/example/domains/itflow.internal.example.com/public_html/quote.php on line 534

[Wed Oct 25 17:35:39.031338 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: date in /home/example/domains/itflow.internal.example.com/public_html/post/quote_model.php on line 2

[Wed Oct 25 17:35:39.031353 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: expire in /home/example/domains/itflow.internal.example.com/public_html/post/quote_model.php on line 3

[Wed Oct 25 17:35:39.031356 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: category in /home/example/domains/itflow.internal.example.com/public_html/post/quote_model.php on line 4

[Wed Oct 25 17:35:39.031359 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: scope in /home/example/domains/itflow.internal.example.com/public_html/post/quote_model.php on line 5

[Wed Oct 25 17:35:39.031370 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: quote_discount in /home/example/domains/itflow.internal.example.com/public_html/post/quote_model.php on line 6

[Wed Oct 25 17:35:39.031373 2023] [fcgid:warn] [pid 22834] [client 10.0.10.26:41402] mod_fcgid: stderr: PHP Notice: Undefined index: HTTP_REFERER in /home/example/domains/itflow.internal.example.com/public_html/post/quote.php on line 192

So something about the redirect or submission to post.php Firefox just doesn't like I think. As Chrome works fine!

A quick google reveals this might be "working as intended" for firefox.
https://blog.mozilla.org/security/2021/03/22/firefox-87-trims-http-referrers-by-default-to-protect-user-privacy/

Following this article and setting network.http.sendRefererHeader to 1 allows the pages to function as intended.

https://www.technipages.com/firefox-enable-disable-referrer/

So not sure if that means that a different method of finding the referrer URL should be defined such as cookie or session storage?

johnny

Just to note I use librewolf which is Firefox just with the telemetry stripped away and extra security privacy features enabled and I still have no problems, are you using any plugins in firefox?

Brodur

If I recall correctly thinking about it now I believe the PrivateInternetAccess VPN extension may modify some privacy settings. That or uBlock origin, but I'd say PIA is the more likely suspect.

wrongecho

Following this article and setting network.http.sendRefererHeader to 1 allows the pages to function as intended.

We use the referer header to know where to send you after you submit a form - usually to the page you came from.