help with mail queue

hugo

Hello, I'm feeling that my email queue is frozen… new emails shows in queue, others is "sending"

How can I troubleshot this?

thx!

psiiota

Those are stuck as there is no "to" email to send the emails to. We should add some logic to deal with these.

hugo

and Why my emails wont come out? its on queue yet

hugo

emails was sent now, Just curious, how this works? why it hold too much to send it

johnny

yes something is deff not right here there should be something in the to column

johnny

@psiiota were you looking into this? I dont want to step on your toes if you are?

johnny

@hugo can you screenshot all columns for us so we can see the queue time

psiiota

No, its behavior I have noticed some things get added to queue with no To field. Such as invoices without an email for the client or tickets scheduling it looks like.

johnny

I see so Im wondering if we can tackle that at the function level. If no to or from email present do not add to the queue

wrongecho

johnny

This should be easy enough to fix with a filter validating the from/to emails.

The real question is why do we have code calling for sending emails when these values are not set.

wrongecho

I've raised a PR to allow cancelling emails in the queue - itflow-org/itflow892

Reviewing the latest ticket scheduling code, it seems that schedule confirmations are sent to contacts even when no contact is set / the contact doesn't have an email. I don't have time to unpick the code, but I would recommend we separate out the $data array to allow the emails to contacts, the agent and watchers to all check for valid emails.

https://github.com/itflow-org/itflow/blob/da54b125c3e6cc377288db01810c80ce3b1dd8c6/post/ticket.php#L1528C14

https://github.com/itflow-org/itflow/blob/da54b125c3e6cc377288db01810c80ce3b1dd8c6/post/ticket.php#L1672

wrongecho

I did some work on the queue to reject invalid emails.

itflow-org/itflow517e8d4