Bug - Unable to update database

JosephWithCOR

Nope. There are three 'Closed' out of 2818 rows.

wrongecho

Hmmm, can you swap the closed status for '5' please and if there aren't any more, drop the login_folder_id column again and see if the update goes through?

johnny

That is interesting, @wrongecho your right it should all be numbers in the ticket status field, I know the demo and my 3 instances were.

So it sounds like The database update was performed but failed so they may have refreshed the screen. and it continued to fail, this time on the first entry which we was creating the login folder id field in the logins table.

So really the update initially failed on changing ticket status from varchar to an int.

JosephWithCOR

johnny So it sounds like The database update was performed but failed so they may have refreshed the screen. and it continued to fail, this time on the first entry which we was creating the login folder id field in the logins table.

That is exactly what I did.

johnny

@JosephWithCOR

Set those 3 Closed tickets to the 5 status as this represents closed from the legend below

Delete the login folder id field Then try to update

Ticket Status Legend

1 New
2 Open
3 On Hold
4 Resolved
5 Closed

johnny

@JosephWithCOR Hey also curious what is the closed_at timestamps on those 3 tickets?

JosephWithCOR

select ticket_status, ticket_closed_at from tickets where ticket_status = "Closed";
+---------------+---------------------+
| ticket_status | ticket_closed_at    |
+---------------+---------------------+
| Closed        | 2024-04-03 12:00:23 |
| Closed        | 2024-04-08 16:34:03 |
| Closed        | 2024-04-08 16:35:04 |
+---------------+---------------------+

johnny

O wow those were awhile, somehow must of slipped in as we were doing the updates at that time

johnny

Dont do anything just yet im gonna try to squeeze in an update that fixes this

wrongecho

@johnny Is it worth editing 1.5.9 to include:

Updating any leftover closed tickets:

UPDATE tickets SET ticket_status = 5 WHERE ticket_status = 'Closed' AND ticket_closed_at IS NULL

Dropping the new column first for anyone else that's also failed

ALTER TABLE logins DROP login_folder_id

JosephWithCOR

update tickets set ticket_status=5 where ticket_status='Closed';

Query OK, 3 rows affected (0.009 sec)

Rows matched: 3 Changed: 3 Warnings: 0

Verify

MariaDB [itflow]> select ticket_status, ticket_closed_at from tickets where ticket_status = "Closed";

Empty set (0.002 sec)

Drop column from logins

alter table logins drop if exists login_folder_id;

Attempt to update through website - Success!!!

Thank you for your help in troubleshooting this

johnny

as @wrongecho pointed out we pushed out a fix

that makes sure all statuses are a number and to only add login folder if it exists

itflow-org/itflow58738de

@E-werd and @klockemy can you please confirm

E-werd

johnny I just did a manual pull and I was able to go through with the database updates through the site.

It appears to be good now.

klockemy

johnny

I logged in this morning and saw the updates but was forced to upgrade the DB and not see the "Update App" buttons. Did a manual git pull then ran the DB updates. All is well.

JosephWithCOR

Will they be able to update the program with a database update pending?

wrongecho

JosephWithCOR

Probably not. We moved database updates to be in front of code updates because it's generally better that you get the latest DB before getting any more code..

JosephWithCOR

Not quite. My instance at work the ticket_status column had 8 'In-Progress'.

To resolve I had to drop the login_folder_id column and set the ticket_status 'In-Progress' to 2.

After I did this I was able to cycle through the database updates.

wrongecho

JosephWithCOR I also had to do this on PR Review. We had a ticket stuck in the old 'Working'.