Asset URI duplication

E-werd

For assets, when filling in both URI and URI2, the URI field value is used for both links on /client_asset_details.php

This bug report also comes with a suggestion: on /client_assets.php, when both URI fields are used, pop up a menu when clicking on the icon in the right column that allows you to select which link you want to visit.

Context: I use Lansweeper for inventory scanning, and Observium for metric collection and alerting. Not all assets fall into this, but some of those fall into one PLUS they have a web interface. Sometimes they have all three, like network equipment. I'm not asking for all that accommodation necessarily, just giving context.

hugo

Hello @E-werd ! Really was some typo missing _2 on variable… fixed in itflow-org/itflow979

I Like the idea of having dropdown to select wich link u want, maybe we can do this, for assets listing and credentials listing. What do you think @wrongecho and @johnny ?

wrongecho

@hugo Nice catch, merged - thank you 🙂

@E-werd The original URI is the one displayed on the asset overview, so populate this with the primary URL for the asset. Regarding adding any extra fields, this is probably best left for when we add custom fields (no idea when they'll come to assets though).

E-werd

@hugo and @wrongecho Just applied the update, can confirm that it's working now. Thanks!

@wrongecho Sounds good, thanks for the acknowledgement. Will wait for custom fields.

johnny

I love the idea of opening a menu will implemet

hugo

johnny

how about this? itflow-org/itflow980
uri and uri2

johnny

I love it @hugo ill pull this request in right away!!

Bigbug

johnny why not put all of them in the […] 3 dot button?
i think it'll make it way more neat

makes sense?

E-werd

Bigbug For me, I do like the additional button. Its presence tells me "there's more to be seen!" If you hide it behind the ellipse menu, then you lose the at-a-glance advantage of it.

To give feedback since it was done--this has made me a lot more efficient. I like it a lot.